fix(form-core): support value types with a custom equals() method in deep equality - #2261
Draft
FrancoKaddour wants to merge 1 commit into
Draft
fix(form-core): support value types with a custom equals() method in deep equality#2261FrancoKaddour wants to merge 1 commit into
FrancoKaddour wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2195
Problem
evaluate(the deep-equality helper used for dirty-checking) reports two equal value-type instances as unequal. Value types likeTemporal.PlainDate, LuxonDateTime, etc. expose their state through private fields/getters, so they have no own enumerable keys and a non-plain prototype — which hits the no-enumerable-keys guard added in #2140 and returnsfalse. A field backed by such a value is then considered dirty even after it's reset to its original value.Fix
Before that guard, delegate to a custom
equals()method when both operands share a constructor that exposes one. This covers Temporal types, LuxonDateTime, Immutable collections, and any value type following theequals()convention, while leaving plain objects/arrays and the existingDate/Map/Setcases untouched.Tests
Added a
form-coreunit test using a value type with a private field and anequals()method (mirroring Temporal's shape — no own enumerable keys). Reverting the fix fails it; the fullform-coresuite passes, plus typecheck and lint.